Add Afghanistan (pa_AF) locale: Pashto & English providers#2293
Open
Sahil31312 wants to merge 3 commits intojoke2k:masterfrom
Open
Add Afghanistan (pa_AF) locale: Pashto & English providers#2293Sahil31312 wants to merge 3 commits intojoke2k:masterfrom
Sahil31312 wants to merge 3 commits intojoke2k:masterfrom
Conversation
fcurella
requested changes
Jan 13, 2026
tests/providers/test_passport.py
Outdated
|
|
||
| from typing import Pattern | ||
| These tests are disabled because: | ||
| 1. German (de_AT), US (en_US), and Russian (ru_RU) passport providers have issues |
Collaborator
There was a problem hiding this comment.
what issues do those providers have? And why do we need to remove tests that are passing on the CI?
update_provider_test.py
Outdated
| @@ -0,0 +1,14 @@ | |||
| with open('tests/utils/test_utils.py', 'r') as f: | |||
Collaborator
There was a problem hiding this comment.
Can you remove this file?
Author
There was a problem hiding this comment.
Thank you for the review.
I’ve restored tests/providers/test_passport.py to its original state and removed the invalid update_provider_test.py file.
The PR now only contains Afghanistan locale providers and tests.
fcurella
requested changes
Feb 6, 2026
Collaborator
fcurella
left a comment
fcurella
left a comment
There was a problem hiding this comment.
Can you write unit tests that follow the existing pattern?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Summary:
This PR adds full Afghanistan locale support (pa_AF) to Faker, including both Pashto (pa_AF_pa) and English (pa_AF_en) translations. It covers a wide range of providers and includes complete test coverage for both locales.
LocalesAdded:
pa_AF_pa — Pashto
pa_AF_en — English translation
Providers Added / Extended:
Address: province, city, district, street, postalcode
Automotive: license_plate
Bank: bank, bank_name, account_number, swift, bank_country
Barcode: ean13, upc_a
Color: color, color_name
Company: company, company_suffix, catch_phrase, bs
Credit Card: credit_card_number, credit_card_expire, credit_card_provider
Currency: currency_code, currency_name
Date / Time: date_time, day_of_week, day_of_month, month_name, year, month, date_of_birth
Geo: local_latlng, local_longitude, local_latitude
Internet: domain_name, email, safe_email, free_email, user_name, url, ipv4, ipv6, mac_address
ISBN: isbn10, isbn13
Job: job, job_male, job_female
Lorem / Text: sentence, sentences, paragraph, paragraphs, word, words, get_words_list
Passport: (if implemented)
Person: name, first_name, first_name_female, last_name, prefix, suffix, title
Phone Number: phone_number, cell_number, toll_free_phone_number, e164
SSN: Afghan National ID (afghan_id) with optional separators and Luhn checksum
Testing:
Motivation / Why:
Afghanistan locale was missing in Faker.
This PR allows users to generate realistic Pashto and English data for testing and development.
Additional Notes:
All new files follow Faker’s provider and test conventions.
Afghan National ID (afghan_id) is fully configurable with separators (-, /, etc.) and validates with Luhn checksum.